Move a held camera key every frame instead of following key repeat - #1381
Conversation
GitHub Actions
Inactive
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9758504989
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d405c90942
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
4adc312 to
be43d5b
Compare
sargunv
changed the title
1 participant
Description
A held camera key now moves the map every frame at one step per
animationDuration, through the same gesture session and camera token as pointer drags, instead of restarting a 300 ms ease on each OS key repeat. A release before a full step eases the remainder, so a tap still moves exactly one step. Held keys add their directions (diagonal pan, pan while zooming; opposite keys cancel), and the hold loop is a child of the session, so KeyUp, focus loss, binding changes, and camera takeover all end it through the session. The animator duration scale applies only to the eased remainder; a zeroanimationDurationfalls back to one jump per press and repeat.Validation
mise run check,MapKeyInputTest(Android host), andKeyAndRotaryInputTest(jvm) pass, with new cases for per-frame motion, release, takeover, taps, repeats, and combined keys. Held arrow keys in the desktop demo move continuously with no pause after the first step; the maintainer also tested manually.AI assistance
Claude Code (Claude Fable 5.1).