Add Apple map presentation outside Compose UI - #1384
Merged
Conversation
sargunv
had a problem deploying
to
cloudflare-pages
September 10, 2026 03:53 — with 
GitHub Actions
Failure
GitHub Actions
Failure
sargunv
had a problem deploying
to
cloudflare-pages
September 10, 2026 04:21 — with
GitHub Actions
Failure
GitHub Actions
Failure
sargunv
had a problem deploying
to
cloudflare-pages
September 10, 2026 04:44 — with
GitHub Actions
Failure
GitHub Actions
Failure
sargunv
force-pushed
the
feat/apple-map-presentation
branch
from
September 12, 2026 19:51
1b7be18 to
f3a980d
Compare
sargunv
marked this pull request as ready for review
September 12, 2026 19:51
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f3a980dda1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
AppleMapPresentationandMaplibreMapViewfor hosting maps in UIKit, SwiftUI, and CarPlay on iOS. The view owns its Metal layer and layout; custom hosts can attach a caller-owned layer. The iOSMaplibreMapcomposable uses the same presentation path while retaining its caller's composition locals and frame clock.Standalone Apple and Android presentations share the runtime composition host. Closing a presentation disposes its style effects and detaches rendering while retaining the caller's map state. Tests cover ownership, failure cleanup, detached recomposition, layer replacement, and UIKit layout.
Add a CarPlay scene and share a small map demo with Android Auto. Zoom buttons use eased camera animations. Simplify Wear OS to a map and a credits button. Consolidate hosting documentation and fix Metal-layer KDoc references so docs and publishing pass on Linux.
Closes #1373.
Validation
mise run test:ios: 774 map tests and 14 location tests passed.mise run build:docspassed, including API generation and internal link checks.mise run checkpassed.CarPlay appears in the simulator launcher, but external-display touch automation could not open it; end-to-end CarPlay interaction and physical CarPlay remain unverified. Hardware CarPlay requires an approved signing profile. Fresh remote CI is pending.
AI assistance
GPT-6 in Codex implemented the original design and performed the code review, rebase, fixes, and validation. This description was drafted with the same assistance.