Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix raster-dem glitches for "no content" tiles (status 204) #5392

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ahaensler
Copy link

Raster-DEM sources like Martin return 204 when there is no content. Maplibre stores such tiles as 1x1 images, introduced in PR #3428 .

This creates glitches while rendering. Elevation looks random and there are backfill errors.

My PR skips 1x1 images and throws 404 instead. This follows the legacy code path for no content tiles.

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

Before
Screenshot From 2025-01-23 02-46-44

After
Screenshot From 2025-01-23 02-47-49

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.94%. Comparing base (3f28408) to head (8bf73ac).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
src/source/raster_dem_tile_worker_source.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5392      +/-   ##
==========================================
- Coverage   91.95%   91.94%   -0.01%     
==========================================
  Files         282      282              
  Lines       38908    38912       +4     
  Branches     6820     6827       +7     
==========================================
+ Hits        35777    35779       +2     
- Misses       3003     3005       +2     
  Partials      128      128              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM
Copy link
Collaborator

HarelM commented Jan 23, 2025

I think a test is needed here.
@xabbu42 @petrsloup any insights on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants