Enhance Package.swift for local framework support and update README w…#29
Open
engali94 wants to merge 2 commits intomaplibre:mainfrom
Open
Enhance Package.swift for local framework support and update README w…#29engali94 wants to merge 2 commits intomaplibre:mainfrom
engali94 wants to merge 2 commits intomaplibre:mainfrom
Conversation
…ith local development instructions.
Author
|
hey @petr-pokorny-1 could you review this pr, thank you |
…ss in build_maplibre.sh
louwers
requested changes
Dec 16, 2024
Member
louwers
left a comment
louwers
left a comment
There was a problem hiding this comment.
The only purpose of this repository is to facilitate automated releases of MapLibre iOS.
Feel free to document how a local XCFramework can be used with SPM. I think a Wiki page in the MapLibre Native repo would be a good place for this (no PR needed, open for contribution).
Adding a build script to this repo is a violation of seperation of concerns. Build logic belongs in the main repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ith local development instructions.