Skip to content

Add Android Goldfish snapshot style reload test - #676

Open
sargunv wants to merge 2 commits into
mainfrom
codex/android-goldfish-style-reload-test
Open

Add Android Goldfish snapshot style reload test#676
sargunv wants to merge 2 commits into
mainfrom
codex/android-goldfish-style-reload-test

Conversation

@sargunv

@sargunv sargunv commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes #675 by adding an API 26 Android Goldfish regression test for composed layers after repeated snapshot style reloads.

Test plan

Passed the focused Kotlin device test on an API 26 ARM64 emulator with ro.kernel.qemu=1, Android x86_64 compilation, targeted hk check, and shell syntax checks.

AI assistance

  • Tools: Codex
  • Context: Used Codex to inspect the Kotlin render-test flow, implement the regression and emulator task option, and run the focused API 26 validation.

@sargunv
sargunv marked this pull request as ready for review September 2, 2026 04:37
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-02T04:50:04.300895Z 4d9b78b New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@greptile-apps

greptile-apps Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds Android Goldfish regression coverage for composed layers after repeated snapshot style reloads and keeps Android x64 EGL tests on API 26.

  • Adds a Kotlin device test that reloads styles and validates the rendered center pixel.
  • Adds an API override to the Android emulator task and includes the API level in managed AVD names.
  • Configures native, Kotlin, and Python Android x64 EGL test paths to use API 26.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
bindings/kotlin/src/androidDeviceTest/kotlin/org/maplibre/nativeffi/render/GoldfishStyleReloadTest.kt Adds an API 26 Goldfish rendering regression test that verifies a composed circle remains visible after repeated style replacement.
mise.toml Adds an emulator API option and ensures the android-x64-egl native test starts the same API 26 emulator later reused by Kotlin.
scripts/boot-android-emulator.sh Includes the requested Android API level in AVD identity so emulator images for different APIs are not conflated.
scripts/test-kotlin-android-device.sh Selects API 26 for the android-x64-egl Kotlin suite, matching the emulator already started earlier in that CI job.
scripts/test-python-android-device.sh Selects API 26 for Python android-x64-egl device tests while retaining the default API for other presets.

Sequence Diagram

sequenceDiagram
  participant CI
  participant Native as Native test task
  participant Emulator as API 26 emulator
  participant Kotlin as Kotlin device suite
  CI->>Native: Run android-x64-egl tests
  Native->>Emulator: Boot API 26 AVD
  Native->>Emulator: Run native tests
  CI->>Kotlin: Run android-x64-egl Kotlin tests
  Kotlin->>Emulator: Request same API 26 AVD
  Emulator-->>Kotlin: Reuse booted emulator
  Kotlin->>Emulator: Run style-reload regression
Loading

Reviews (2): Last reviewed commit: "Keep Android x64 EGL tests on API 26" | Re-trigger Greptile

Comment thread scripts/test-kotlin-android-device.sh

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 02de32ac8b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/test-kotlin-android-device.sh
@sargunv
sargunv force-pushed the codex/android-goldfish-style-reload-test branch from 02de32a to 4d9b78b Compare September 2, 2026 04:46
@sargunv
sargunv enabled auto-merge (squash) September 2, 2026 04:50
@sargunv
sargunv disabled auto-merge September 2, 2026 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Android Goldfish regression test for repeated snapshot style reload

1 participant