Add Android Goldfish snapshot style reload test - #676
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Greptile SummaryThis PR adds Android Goldfish regression coverage for composed layers after repeated snapshot style reloads and keeps Android x64 EGL tests on API 26.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| bindings/kotlin/src/androidDeviceTest/kotlin/org/maplibre/nativeffi/render/GoldfishStyleReloadTest.kt | Adds an API 26 Goldfish rendering regression test that verifies a composed circle remains visible after repeated style replacement. |
| mise.toml | Adds an emulator API option and ensures the android-x64-egl native test starts the same API 26 emulator later reused by Kotlin. |
| scripts/boot-android-emulator.sh | Includes the requested Android API level in AVD identity so emulator images for different APIs are not conflated. |
| scripts/test-kotlin-android-device.sh | Selects API 26 for the android-x64-egl Kotlin suite, matching the emulator already started earlier in that CI job. |
| scripts/test-python-android-device.sh | Selects API 26 for Python android-x64-egl device tests while retaining the default API for other presets. |
Sequence Diagram
sequenceDiagram
participant CI
participant Native as Native test task
participant Emulator as API 26 emulator
participant Kotlin as Kotlin device suite
CI->>Native: Run android-x64-egl tests
Native->>Emulator: Boot API 26 AVD
Native->>Emulator: Run native tests
CI->>Kotlin: Run android-x64-egl Kotlin tests
Kotlin->>Emulator: Request same API 26 AVD
Emulator-->>Kotlin: Reuse booted emulator
Kotlin->>Emulator: Run style-reload regression
Reviews (2): Last reviewed commit: "Keep Android x64 EGL tests on API 26" | Re-trigger Greptile
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 02de32ac8b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
02de32a to
4d9b78b
Compare
Summary
Fixes #675 by adding an API 26 Android Goldfish regression test for composed layers after repeated snapshot style reloads.
Test plan
Passed the focused Kotlin device test on an API 26 ARM64 emulator with
ro.kernel.qemu=1, Android x86_64 compilation, targetedhk check, and shell syntax checks.AI assistance