Skip to content

Commit

Permalink
Fix icon label isn't centered with the icon for CJK/local glyphy on i…
Browse files Browse the repository at this point in the history
…OS (#3108)

Co-authored-by: Yingfang <[email protected]>
  • Loading branch information
wangyingfang and Yingfang authored Dec 30, 2024
1 parent 8023e6d commit 525a313
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion platform/darwin/src/local_glyph_rasterizer.mm
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ CGContextHandle context(CGBitmapContextCreate(

// Mimic glyph PBF metrics.
metrics.left = Glyph::borderSize;
metrics.top = 4;
metrics.top = -Glyph::borderSize;

// Move the text upward to avoid clipping off descenders.
CGFloat descent;
Expand Down
Binary file modified test/fixtures/local_glyphs/ping_fang/expected.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified test/fixtures/local_glyphs/ping_fang_semibold/expected.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 525a313

Please sign in to comment.