Don't reuse git dir across runs node-ci and ios-ci #1182
Conversation
Size test resultOld size: bytes |
| run: | | ||
| auth_header="$(git config --local --get http.https://github.com/.extraheader)" | ||
| git submodule sync --recursive | ||
| git -c core.longpaths=true -c "http.extraheader=$auth_header" -c protocol.version=2 submodule update --init --force --recursive || true |
There was a problem hiding this comment.
just an fyi, there is a reason we did it this way. On the windows platform the normal checkout has issues with long file names, which this got around.
It may be possible that with the recent reorg of files that this path issue was no longer a problem, but we would have to look out for that.
There was a problem hiding this comment.
I remember this causing problems for me cloning on my windows system but I just did a recursive clone and it seems fine now. I checked and I still have long path support disabled at the moment.
If I recall correctly it was test fixtures in a submodule that had extremely long file names which caused problems.
There was a problem hiding this comment.
Thanks! I am indeed running into that problem when I do a recursive merge.
|
@mwilsnd This seems to be the issue actions/checkout#354 The problem is only showing up on self-hosted runners. I created a new issue there and I deleted the |
We recently deleted a submodule, but the self-hosted runners for Node.js and macOS now fail with the message that the deleted submodule cannot be found in
.gitmodules.This can be avoided by not re-using the same git directory across runs.