[Qt for WebAssembly; opengl-2 branch] Fix http_file_source

[birkskyum]

The manual changes required for qt webgl1 compilation are here fixed with compile conditionals:

https://github.com/birkskyum/maplibre-native-wasm/tree/main/qt-opengl2#changes-needed-to-the-code

(i'll make sure to clean up this branch - made it in main repo instead of fork by accident)

[ntadej]

This is still causing a leak in WASM build. As this is not urgent, let me try to find a proper fix.

[ntadej]

Let me also do a review.

[birkskyum]

This is still causing a leak in WASM build.

This actually closes a leak in WASM build by allowing the browser to abort tile requests. It's easy to verify, because without this fix the app stalls and crashes shortly after boot due to a lack of cleanup.

@ntadej Can we maybe merge this fix, so that things work out-of-the-box, and then at your convenience you can look into improving on it further if the opengl-2 branch still is relevant at the time?

[birkskyum]

@ntadej , is it okay with you if we merge the fix, so that the code can at least run without the manual edits, and then investigate the persisting memory leak later on?

[louwers]

@birkskyum Your suggestion sounds reasonable to me. I think @ntadej was afk last month, let's give him a chance to respond this weekend and merge on Monday otherwise.

[ntadej]

Sorry, I did not see that you condition now with WASM. I think it's fine for now until I have time to investigate closer.

Note that I am a bit disappointed in MapLibre memory usage so I plan to investigate eventually if there are not more leaks.

[ntadej]

Before we merge, is this already in main? If not, in principle all changes go there first to avoid forgetting something.

[louwers]

No it's not @birkskyum Could you make a new PR that targets main?

[josxha]

It's possible to change the targeted branch of the pull request.
https://docs.github.com/de/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-base-branch-of-a-pull-request

[louwers]

@josxha I tried, but then there's a bunch of unrelated changes in the PR...