Fix LineBucket::addGeometry() empty coordinates. #2959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgalvan
approved these changes
Oct 23, 2024
Are there docs for how to run the unit tests? When I run the mbgl-test-runner project, it says: [==========] Running 0 tests from 0 test suites. I tried filtering for Buckets.LineBucket, but that didn't help. |
|
That should work. What platform are you on? Could be that we don't have it set up properly for Windows. |
I'm on Windows 11 with GLFW as the platform. |
stefankarschti
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix avoids using a negative number to index the coordinates inside the "len" lambda in LineBucket::addGeometry(). It does an early return similar to the one on line ~90 for invalid geometry.