Expose Android NativeMapView and move creation to the ModuleProvider #3040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louwers
reviewed
Nov 22, 2024
| @@ -44,7 +44,7 @@ | |||
| import java.util.List; | |||
|
|
|||
| // Class that wraps the native methods for convenience | |||
| final class NativeMapView implements NativeMap { | |||
| public final class NativeMapView implements NativeMap { | |||
There was a problem hiding this comment.
Should we drop the final so it's easier to create a custom NativeMap with inheritance?
There was a problem hiding this comment.
Let me do some testing, I'm currently uncertain if the JNI bindings will work as expected with a derived class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the NativeMapView implementation and delegates construction to the ModuleProvider via a new factory method. This allows an external library to implement a custom NativeMapView and replace it at runtime by implementing the ModuleProvider interface. This enables a much cleaner method of working with the native core layer of MapLibre in Android projects.
For existing users, nothing will change. Advanced users which already implement their own ModuleProvider will need to implement the new
createNativeMapViewmethod. The implementation of this method can be copied from the includedModuleProviderImpl.javafile.