Add page to Developer Docs on Render Tests#3377
Merged
louwers merged 3 commits intomaplibre:mainfrom Apr 11, 2025
Merged
Conversation
Contributor
Bloaty Results (iOS) 🐋Compared to main Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-3377-compared-to-main.txt |
cgalvan
approved these changes
Apr 11, 2025
nnhubbard
pushed a commit
to nnhubbard/maplibre-native
that referenced
this pull request
Apr 16, 2025
…to cachly-production * 'main' of https://github.com/maplibre/maplibre-native: TextureViewRenderThread#eventQueue should be LinkedList (maplibre#3397) Remove legacy renderer from source, build files and CI (maplibre#3384) Fix std::bad_function_call in event handling (maplibre#3388) Add page to Developer Docs on Render Tests (maplibre#3377) Unignore some Android Instrumentation Tests (maplibre#3274) [pre-commit.ci] pre-commit autoupdate (maplibre#3367) Prepare MapLibre Android 11.8.6 release (maplibre#3372) Prevent exception SymbolLocationLayerRenderer with new style (maplibre#3369) Sync surface destruction with main thread (maplibre#3368) Add MLNDefines.h to make sure Metal backend is available in headers (maplibre#3363) Retry with curl on CI (maplibre#3364) Fix dead links README.md (maplibre#3361) Stick to CMake 3.41.1 on CI for now (maplibre#3362)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a page to the Developer Documentation on the render tests. This page explains how to run them, what types of tests there are, how to create them, how to update them.
For this PR I documented the directory structure so I came across a lot of cruft which I also removed. There is a separate issue to clean-up unused manifests.
I am aware there is some room for improvement in the explanation of how to update them, because sometimes render tests require platform-specific expected images. Also, you need to generate expectations for each platform. That is something to be addressed in a follow-up, I think for now this is a good introduction.
Related issue #2853