Skip to content
iOS

Consistent Code Style #94

Sign in to view logs

Consistent Code Style

Consistent Code Style #94

Triggered via pull request April 17, 2024 18:19
@Patrick-KladekPatrick-Kladek
synchronize #37
feature/consistent-code-style-take-2
Status Success
Total duration 12m 28s
Artifacts –

ios.yml

on: pull_request
Code Style
11s
Code Style
Build and Test
12m 19s
Build and Test
Fit to window
Zoom out
Zoom in

Annotations

30 warnings and 1 notice
Code Style: MapboxNavigation/CarPlayManager.swift#L572
FIXMEs should be resolved (Unable to tilt map during rout...) (todo)
Code Style: MapboxNavigation/InstructionPresenter.swift#L239
FIXMEs should be resolved (Can we work with the image dir...) (todo)
Code Style: MapboxNavigation/NavigationMapView.swift#L743
TODOs should be resolved (Change to point-based distance...) (todo)
Code Style: MapboxNavigation/CarPlayNavigationViewController.swift#L267
TODOs should be resolved (handle lanes.) (todo)
Code Style: MapboxNavigation/CarPlayNavigationViewController.swift#L294
TODOs should be resolved (no such method exists, and the...) (todo)
Code Style: MapboxCoreNavigation/NavigationSettings.swift#L79
Prefer the new block based KVO API with keypaths when using Swift 3.2 or later (block_based_kvo)
Code Style: MapboxCoreNavigation/RouteProgress.swift#L26
TODOs should be resolved (Set stepIndex to 0 or last ind...) (todo)
Code Style: MapboxCoreNavigation/DistanceFormatter.swift#L112
`where` clauses are preferred over a single `if` inside a `for` (for_where)
Code Style: MapboxCoreNavigation/RouteController.swift#L175
An object should only remove itself as an observer in `deinit` (notification_center_detachment)
Code Style: MapboxCoreNavigation/RouteController.swift#L664
Prefer `!= nil` over `let _ =` (unused_optional_binding)
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'NSDictionary+MLNAdditions.h'
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'MLNStyleLayerManager.h'
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'NSBundle+MLNAdditions.h'
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'NSArray+MLNAdditions.h'
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'MLNMapAccessibilityElement.h'
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'UIDevice+MLNAdditions.h'
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'MLNConversion.h'
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'MLNRendererConfiguration.h'
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'MLNValueEvaluator.h'
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'MLNUserLocationHeadingIndicator.h'
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'NSDictionary+MLNAdditions.h' [-Wincomplete-umbrella]
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'NSArray+MLNAdditions.h' [-Wincomplete-umbrella]
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'MLNConversion.h' [-Wincomplete-umbrella]
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'MLNUserLocationHeadingIndicator.h' [-Wincomplete-umbrella]
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'MLNUserLocationHeadingArrowLayer.h' [-Wincomplete-umbrella]
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'MLNMapView+Metal.h' [-Wincomplete-umbrella]
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'NSComparisonPredicate+MLNAdditions.h' [-Wincomplete-umbrella]
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'MLNMapView+Impl.h' [-Wincomplete-umbrella]
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'NSValue+MLNStyleAttributeAdditions.h' [-Wincomplete-umbrella]
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'UIView+MLNAdditions.h' [-Wincomplete-umbrella]
Build and Test
Tests Passed: 0 failed, 0 skipped, 93 total (7.429 seconds)