Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Map without Navigation #41

Closed
wants to merge 1 commit into from
Closed

Use Map without Navigation #41

wants to merge 1 commit into from

Conversation

Patrick-Kladek
Copy link
Contributor

Description

We need to start a navigation from an existing map, without presenting another map as overlay. To achieve this we need to show a normal map first and then assign a route which will start navigation

Open Tasks

  • make route parameter optional

Infos for Reviewer

@boldtrn
Copy link
Collaborator

boldtrn commented May 14, 2024

Thanks for opening this PR. In general I like the idea of a "Navigation" without a route (we have this in our app as well). I haven't tested your PR, but while scanning the code, it seems like the camera and puck won't work without the route?

Let's maybe discuss the expectation for this mode first:
So I would expect that the navigation without route would still focus around the user location and follow the user location while moving. Is this what you are aiming for?

@Patrick-Kladek
Copy link
Contributor Author

@boldtrn this is early work in progress, I made this PR to share my progress with my colleagues so its nowhere near working. In fact right now you can only initialize NavigationViewController without a Route, however none of the UI reflects that, camera is pointing to (0, 0) coordinates instead of current location, location puck is not appearing and so on.

So I would expect that the navigation without route would still focus around the user location and follow the user location while moving. Is this what you are aiming for?

Yes thats exactly what I want. You start with a normal map, where you can tap POIs, see your current location and so on. Once you assign a route, it will switch to navigation mode where you will see the navigation UI, spoken instructions, ...

@boldtrn
Copy link
Collaborator

boldtrn commented May 14, 2024

Yeah no worries, I just saw it and figured I give a bit of feedback as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants