Update MapboxDirections #89
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for looking into this. Yes this was exactly what I expected, things got renamed and this has a direct effect on the navigation code. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the last Maplibre Meeting we decided to use & update MapboxDirections to the original Mapbox version, away from this fork https://github.com/flitsmeister/mapbox-directions-swift.
We also have a Github discussion about this here: #87
Open Tasks
Infos for Reviewer
The fork is way behind so integrating MapboxDirections is not an easy task. MapboxDirections is now optimized for Swift. One of the major changes is that
VisualInstructionComponentis now renamed toVisualInstruction.Component, an enum with associated values. This is incompatible with how we present banners & spoken instructions. I've tried to make the code work but I've definitely broken something.This PR state is far from finished or even reviewable. I've fixed around 200 build errors, just so that another 90 appeared. Given that I don't even know if this works I'm stopping here for now, but keeping this PR if anyone wants to continue off of it.