WIP: Chunked image encoding #799
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talaj
force-pushed
the
image-encode-chunked
branch
from
7a92a2e to
c553d8a
Compare
talaj
force-pushed
the
image-encode-chunked
branch
3 times, most recently
from
779358f to
4698ba4
Compare
|
Thinking about this again, would this make more sense to design something similar to node streams? https://nodejs.org/api/stream.html#stream_class_stream_readable. This could enable more generic IO systems to be built from this interface perhaps? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to implement #793.
Encoding runs on a separate thread, encoded chunks are stored into a queue and yielded into the main thread.
See added unit tests.