Skip to content

Conversation

rebecca-src
Copy link

Hello Marc,
Thank you for this awesome project 😃
I was experimenting with an Android build of Freya and thought, maybe it could be useful to the project.

Changes in window event loop and state, otherwise the screen will be black on android or when the screen is rotated
@rebecca-src rebecca-src requested a review from marc2332 as a code owner April 11, 2025 08:30
@marc2332 marc2332 added the enhancement 🔥 New feature or request label Apr 11, 2025
@marc2332
Copy link
Owner

Wooooooooow, this is crazy, I will have a look asap!!

Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 41 lines in your changes missing coverage. Please review.

Project coverage is 74.52%. Comparing base (ff85c23) to head (e627f35).
Report is 139 commits behind head on main.

Files with missing lines Patch % Lines
crates/winit/src/window_state.rs 0.00% 38 Missing ⚠️
crates/winit/src/renderer.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1142      +/-   ##
==========================================
- Coverage   74.55%   74.52%   -0.04%     
==========================================
  Files         233      233              
  Lines       28934    28946      +12     
==========================================
  Hits        21571    21571              
- Misses       7363     7375      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marc2332
Copy link
Owner

I had some issues while trying to build this on Windows, you used Linux right?

@rebecca-src
Copy link
Author

Yes, I build on Linux and MacOS, but hoped Windows would work too.
Did you have problems building the Rust project or compiling the Android Studio project?

@w568w
Copy link

w568w commented Apr 22, 2025

Thanks for your work. I'd like to point out a trivial issue that you might want to exclude .gradle directories from your commits, as they contain local file system build caches, VCS caches, etc.

Just FYI, it built seamlessly on my Windows machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants