-
-
Notifications
You must be signed in to change notification settings - Fork 92
Notify rust examples #1330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Notify rust examples #1330
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the CI is failing, maybe some methods are not available in MacOS?
examples/notify_rust.rs
Outdated
use notify_rust::{Hint, Notification}; | ||
|
||
fn main() { | ||
launch_with_props(app, "Router Example", (550.0, 400.0)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not your fault, I changed the name of this method yesterday :D
launch_with_props(app, "Router Example", (550.0, 400.0)); | |
launch_with_params(app, "Router Example", (550.0, 400.0)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I noticed that was changed after I made the PR hehe.
So, I'm not sure what's the best way to resolve this. At first I tried using #[cfg(target_os = ...)] rules like in the original notify-rust examples to include the problematic examples conditionally, but then errors with the formatting started showing up, so in the end I just removed all the examples that were Linux/Unix specific.
Now, there's an error on the Ubuntu build about a "blocking" module in the zbus crate. That, I don't know what to do about 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I'm not sure what's the best way to resolve this. At first I tried using #[cfg(target_os = ...)] rules like in the original notify-rust examples to include the problematic examples conditionally, but then errors with the formatting started showing up, so in the end I just removed all the examples that were Linux/Unix specific.
I can have a look at this I test the PR properly, no worries
Now, there's an error on the Ubuntu build about a "blocking" module in the zbus crate. That, I don't know what to do about 😅
That's very weird, I will have a look at that too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! Thank you so much. Let me know if there is anything I can help with.
@mistermaxis Seems like the CI is still failing 👀 |
Yes, I haven't been able to figure out how to remove these errors, which come from a different crate (zbus) and doesn't mention anything about any change in that module (blocking-api) in recent versions. Also, dependency versions are not something I'm all that familiar with. I will keep investigating, probably consult their community. At least now it fails on my machine too, so that should help me make progress more easily. |
Closes #1265
Added example file for notify-rust examples: