Add support for binding lists, arrays, and structs to prepared queries#423
Add support for binding lists, arrays, and structs to prepared queries#423taniabogatsch merged 10 commits intomarcboeker:mainfrom wmTJc9IK0Q:bind-complex-types
Conversation
taniabogatsch
left a comment
There was a problem hiding this comment.
Hi, @wmTJc9IK0Q, Thanks for your work on this! I've left some comments :)
There was a problem hiding this comment.
@taniabogatsch Thanks for the review. I have addressed most of the feedback. We just need to decide on the path forward on the int casts in value.go
taniabogatsch
left a comment
There was a problem hiding this comment.
Thanks for implementing the review feedback! I just had another pass and only found a few minor things, so I quickly added and pushed them myself.
I've also left a few comments to explain what I did.
What do you think, does this look ready from your side now? :)
|
@taniabogatsch Thanks for the small fixes. This looks good to me. |
|
I fixed one bug where you could not bind an |
|
Thank you! And great catch with the |
Closes #343
I have added support for binding list, array, and struct types to prepared queries.
I have not yet added support for enums (should be achievable, but can be a separate PR). Maps are not possible until duckdb/duckdb#14613 is merged upstream, which seems to be stalled right now.
Open to any feedback to get this merged, thanks.