Skip to content

Commit

Permalink
Bug 1950674 [wpt PR 50969] - Cleanup Canvas text direction tests, a=t…
Browse files Browse the repository at this point in the history
…estonly

Automatic update from web-platform-tests
Cleanup Canvas text direction tests

Fix various style issues. And add tests for default, valid and invalid
values. The tests for valid and default values fail because we never
report `inherit`, but report the computed value instead.

A spec issue was filed for the round-tripping of `direction` and it was
resolved to return "inherit" rather than the computed value. See
whatwg/html#10884 and the spec PR at
whatwg/html#10873.

The code will not be changed to pass these tests until the results of
UseCounters have been reviewed to identify how often this change might
affect sites. A search of HTTP Archive did not find failure cases,
mostly because Firefox already returns "inherit" so sites check for
that.

Change-Id: I39645acd997786c22d4983f84a9d17c7b976797b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6277644
Reviewed-by: Andres Ricardo Perez <andresrperezchromium.org>
Commit-Queue: Stephen Chenney <schenneychromium.org>
Cr-Commit-Position: refs/heads/main{#1425228}

--

wpt-commits: e0a8cfa0bbb879d889e2ddf8b2b4161feb6a2204
wpt-pr: 50969

UltraBlame original commit: 95c6e5bb08ff14626bab0ee8d8ffb3bdc502947f
  • Loading branch information
marco-c committed Mar 1, 2025
1 parent 082d052 commit c2daa2f
Show file tree
Hide file tree
Showing 24 changed files with 3,104 additions and 147 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@
HTML
>
<
html
>
<
meta
charset
=
Expand All @@ -17,9 +14,6 @@
"
>
<
head
>
<
title
>
HTML5
Expand Down Expand Up @@ -121,10 +115,6 @@
script
>
<
/
head
>
<
body
onload
=
Expand Down Expand Up @@ -167,7 +157,3 @@
/
body
>
<
/
html
>
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@
HTML
>
<
html
>
<
meta
charset
=
Expand All @@ -17,9 +14,6 @@
"
>
<
head
>
<
title
>
HTML5
Expand Down Expand Up @@ -141,10 +135,6 @@
script
>
<
/
head
>
<
body
onload
=
Expand Down Expand Up @@ -187,7 +177,3 @@
/
body
>
<
/
html
>
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@
"
>
<
head
>
<
title
>
HTML5
Expand Down Expand Up @@ -216,10 +213,6 @@
script
>
<
/
head
>
<
body
onload
=
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@
HTML
>
<
html
>
<
meta
charset
=
Expand All @@ -17,9 +14,6 @@
"
>
<
head
>
<
title
>
HTML5
Expand Down Expand Up @@ -163,13 +157,6 @@
style
>
<
/
head
>
<
body
>
<
canvas
id
=
Expand Down Expand Up @@ -276,6 +263,7 @@
direction
is
inherit
.
ctx
.
font
Expand Down Expand Up @@ -310,11 +298,3 @@
/
script
>
<
/
body
>
<
/
html
>
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@
"
>
<
head
>
<
title
>
HTML5
Expand Down Expand Up @@ -246,10 +243,6 @@
style
>
<
/
head
>
<
body
onload
=
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@
"
>
<
head
>
<
title
>
HTML5
Expand Down Expand Up @@ -229,10 +226,6 @@
script
>
<
/
head
>
<
body
onload
=
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@
HTML
>
<
html
>
<
meta
charset
=
Expand All @@ -17,9 +14,6 @@
"
>
<
head
>
<
title
>
HTML5
Expand Down Expand Up @@ -230,10 +224,6 @@
style
>
<
/
head
>
<
body
onload
=
Expand Down Expand Up @@ -281,7 +271,3 @@
/
body
>
<
/
html
>
Loading

0 comments on commit c2daa2f

Please sign in to comment.