Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Main Branch #32

Merged
merged 27 commits into from
Nov 28, 2023
Merged

Conversation

FThinker
Copy link
Contributor

Fixed IP getting blocked by using a rotating proxy, increased request interval to 2 seconds.

Copy link
Collaborator

@DavidePiccione DavidePiccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marconicivitavecchia/backend Date un'occhiata ai commenti, quando si risolve tutto facciamo il merge

Backend/mqtt.js Show resolved Hide resolved
Frontend/app.js Outdated Show resolved Hide resolved
documentazione Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marconicivitavecchia/backend La documentazione va messa nel README.md che si trova nella vostra repository

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@DavidePiccione DavidePiccione Nov 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brucobruce va bene il commit da4b168, ma dovete anche eliminare il file che si chiama "documentazione" che sta fuori dalla cartella backend. La documentazione poi andrebbe formattata. Trovate un esempio in questo file:

Codice Sorgente Risultato Finale
Source Code Result

Cercate anche di seguire le linee guida per la scrittura della documentazione.

Rimane poi anche questo problema che va risolto per fare il merge: #32 (comment)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Va bene il commit 677e8a9 per eliminare il file "documentazione", rimangono però questi due punti che devono ancora essere risolti:

  1. Dovete formattare correttamente la documentazione come già indicato nel commento precedente
  2. Dovete risolvere questa issue: [2] Come sviluppatore vorrei ci fosse una buona documentazione sul funzionamento della backend IFC-Backend-dev#4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lo so, stiamo aspettando @brucobruce @Splyxxx

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marconicivitavecchia/backend dovreste risolvere anche questa issue prima di fare il merge:
marconicivitavecchia#4 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brucobruce and others added 3 commits November 19, 2023 10:22
Docs has been moved to README.rst
documentazione aggiornata
Copy link
Collaborator

@DavidePiccione DavidePiccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning: README.rst is still Work in Progress

@DavidePiccione DavidePiccione merged commit d762fa6 into marconicivitavecchia:dev Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants