WIP: C: Use hb_string_T for token_T.value
#687
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoroth
changed the title
hb_string_T for token_T.value`hb_string_T for token_T.value
timkaechele
force-pushed
the
token-value-string
branch
3 times, most recently
from
cad26cb to
9488839
Compare
timkaechele
force-pushed
the
token-value-string
branch
2 times, most recently
from
b29d6cc to
b867795
Compare
timkaechele
force-pushed
the
token-value-string
branch
from
b867795 to
083a56b
Compare
timkaechele
force-pushed
the
token-value-string
branch
from
57929af to
1039634
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
token_T.valueto usehb_string_Tand adapts the call sites.This is done in order to reduce the number of string copies necessary