Parser: Fix ERB control flow tags in attribute positions #873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoroth
force-pushed
the
fix-erb-control-flow-in-attributes
branch
from
a211b48 to
cb7ae34
Compare
This was referenced Nov 13, 2025
timkaechele
reviewed
Dec 6, 2025
| )) { | ||
| if (token_is(parser, TOKEN_ERB_START)) { | ||
| const char* tag = parser->current_token->value; | ||
| bool is_output_tag = (tag[2] == '='); |
Contributor
There was a problem hiding this comment.
Question: What if the tag length is less than 3?
Contributor
There was a problem hiding this comment.
Nitpick: Remove the braces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the parser to correctly handle ERB control flow tags when parsing HTML attributes.
Previously, control flow tags like
<% if %>,<% end %>, and<%# comment %>were incorrectly included as part of attribute names and values. Now, only ERB output tags (<%=,<%==) can be part of attribute names, while control flow tags properly terminate attribute name and attribute value parsing.This enables patterns like this, where there is no space between the closing
%>and the attribute name:Resolves #872