Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion lib/herb/engine/debug_visitor.rb
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,9 @@ def in_excluded_context?
excluded_tags = ["script", "style", "head", "textarea", "pre"]
return true if excluded_tags.any? { |tag| @element_stack.include?(tag) }

return true if @erb_block_stack.any? { |node| javascript_tag?(node.content.value.strip) }
if @erb_block_stack.any? { |node| javascript_tag?(node.content.value.strip) || include_debug_disable_comment?(node.content.value.strip) }
return true
end

false
end
Expand Down Expand Up @@ -355,6 +357,14 @@ def javascript_tag?(code)

false
end

def include_debug_disable_comment?(code)
cleaned_code = code.strip.gsub(/\s+/, " ")

return true if cleaned_code.match?(/#\s*herb:debug\sdisable\s*$/)

false
end
end
end
end
2 changes: 2 additions & 0 deletions sig/herb/engine/debug_visitor.rbs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 20 additions & 0 deletions test/engine/debug_mode_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -402,5 +402,25 @@ class DebugModeTest < Minitest::Spec

assert_compiled_snapshot(template, debug: true)
end

test "block without debug disable comment content erb expressions get debug spans" do
template = <<~ERB
<%= content_for :sidebar do %>
<div><%= "Sidebar content" %></div>
<% end %>
ERB

assert_compiled_snapshot(template, debug: true)
end

test "block with debug disable comment content erb expressions do NOT get debug spans" do
template = <<~ERB
<%= content_for :sidebar do # herb:debug disable %>
<div><%= "Sidebar content" %></div>
<% end %>
ERB

assert_compiled_snapshot(template, debug: true)
end
end
end

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading