Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a race condition where concurrent async calls could trigger multiple redundant token refresh requests.
When multiple coroutines executed simultaneously (e.g., via
asyncio.gather), they all passed the token expiry check and independently called the refresh endpoint, resulting in N duplicate refresh requests.Solution
Introduced an
asyncio.Lockto synchronize token refresh:Example (Before vs After)
Before
→ 10 token refresh requests ❌
After
→ 1 token refresh request ✅
→ Remaining calls reuse refreshed token
Safety & Scope
Notes
This follows a standard concurrency control pattern for async systems to prevent race conditions during shared resource updates.
Happy to adjust if there’s a preferred synchronization approach.