Give legacy questions a default model if it is not set

marcusgreen · May 23, 2024 · 8e51729 · 8e51729
1 parent e60f1c2
commit 8e51729
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/question.php b/question.php
@@ -186,7 +186,7 @@ public function grade_response(array $response) : array {
      * @param string $aiprompt
      * @param number $defaultmark
      * @param string $markscheme
-     * @return void
+     * @return string;
      */
     public function build_full_ai_prompt($response, $aiprompt, $defaultmark, $markscheme) {
         $responsetext = strip_tags($response);

diff --git a/questiontype.php b/questiontype.php
@@ -147,7 +147,13 @@ protected function initialise_question_instance(question_definition $question, $
         $question->aiprompt = $questiondata->options->aiprompt;
         $question->markscheme = $questiondata->options->markscheme;
         $question->sampleanswer = $questiondata->options->sampleanswer;
-        $question->model = $questiondata->options->model;
+        /* Legacy quesitons may not have a model set, so assign the first in the settings */
+        if(empty($question->model)) {
+            $model = explode(",", get_config('tool_aiconnect', 'model'))[0];
+            $question->model = $model;
+        } else {
+            $question->model = $questiondata->options->model;
+        }
     }
     /**
      * Delete a question from the database