Lint fixes

marcusgreen · Apr 23, 2024 · ab2fe22 · ab2fe22
1 parent a681216
commit ab2fe22
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 24 deletions.
diff --git a/backup/moodle2/backup_qtype_aitext_plugin.class.php b/backup/moodle2/backup_qtype_aitext_plugin.class.php
@@ -46,10 +46,10 @@ protected function define_question_plugin_structure() {
         $plugin->add_child($pluginwrapper);
 
         // Now create the qtype own structures.
-        $aitext = new backup_nested_element('aitext', ['id'], array(
+        $aitext = new backup_nested_element('aitext', ['id'], [
                 'aiprompt', 'responseformat', 'responsefieldlines', 'minwordlimit', 'maxwordlimit',
                 'graderinfo', 'graderinfoformat', 'responsetemplate',
-                'responsetemplateformat', 'maxbytes'));
+                'responsetemplateformat', 'maxbytes']);
 
         // Now the own qtype tree.
         $pluginwrapper->add_child($aitext);

diff --git a/question.php b/question.php
@@ -138,16 +138,16 @@ public function grade_response(array $response) : array {
         if (is_array($response)) {
             $responsetext = strip_tags($response['answer']);
             $responsetext = '[['.$responsetext.']]';
-            $prompt = get_config('qtype_aitext','prompt');
+            $prompt = get_config('qtype_aitext', 'prompt');
             $prompt = preg_replace("/\[responsetext\]/", $responsetext, $prompt);
             $prompt .= ' '.trim($this->aiprompt);            if ($this->markscheme > '') {
                 $prompt .= ' '.$this->markscheme;
             } else {
-                /** @todo should this be a plugin setting value? */
+                // Todo should this be a plugin setting value?.
                 $prompt .= ' Set marks to null in the json object.'.PHP_EOL;
             }
 
-            $prompt .= ' '.trim(get_config('qtype_aitext','jsonprompt'));
+            $prompt .= ' '.trim(get_config('qtype_aitext', 'jsonprompt'));
             $prompt .= ' respond in the language '.current_language();
 
             $llmresponse = $ai->prompt_completion($prompt);
@@ -161,7 +161,7 @@ public function grade_response(array $response) : array {
             $grade = [0 => 0, question_state::$needsgrading];
         } else {
             $fraction = $contentobject->marks / $this->defaultmark;
-            $grade = array($fraction, question_state::graded_state_for_fraction($fraction));
+            $grade = [$fraction, question_state::graded_state_for_fraction($fraction)];
         }
          // The -aicontent data is used in question preview. Only needs to happen in preview.
         $this->insert_attempt_step_data('-aiprompt', $prompt);
@@ -189,7 +189,7 @@ public function process_feedback(string $feedback) {
         } else {
             $contentobject = (object) [
                                         "feedback" => $feedback,
-                                        "marks" => null
+                                        "marks" => null,
                                         ];
         }
         return $contentobject;

diff --git a/settings.php b/settings.php
@@ -24,22 +24,30 @@
 defined('MOODLE_INTERNAL') || die;
 
 if ($ADMIN->fulltree) {
-    $settings->add(new admin_setting_configtext('qtype_aitext/disclaimer',
-            new lang_string('disclaimer', 'qtype_aitext'),
-            new lang_string('disclaimer_setting', 'qtype_aitext'),
-            '(Response provided by ChatGPT)'));
-    $settings->add(new admin_setting_configtextarea('qtype_aitext/prompt',
-            new lang_string('prompt', 'qtype_aitext'),
-            new lang_string('prompt_setting', 'qtype_aitext'),
-            'in [responsetext] analyse the part between [[ and ]] as follows.',
-			PARAM_RAW,20,3));
-	$settings->add(new admin_setting_configtextarea('qtype_aitext/jsonprompt',
-            new lang_string('jsonprompt', 'qtype_aitext'),
-            new lang_string('jsonprompt_setting', 'qtype_aitext'),
-            'Return only a JSON object which enumerates a set of 2 elements.The JSON object should be in
+    $settings->add(new admin_setting_configtext(
+        'qtype_aitext/disclaimer',
+        new lang_string('disclaimer', 'qtype_aitext'),
+        new lang_string('disclaimer_setting', 'qtype_aitext'),
+        '(Response provided by ChatGPT)'
+    ));
+    $settings->add(new admin_setting_configtextarea(
+        'qtype_aitext/prompt',
+        new lang_string('prompt', 'qtype_aitext'),
+        new lang_string('prompt_setting', 'qtype_aitext'),
+        'in [responsetext] analyse the part between [[ and ]] as follows.',
+        PARAM_RAW,
+        20,
+        3
+    ));
+    $settings->add(new admin_setting_configtextarea(
+        'qtype_aitext/jsonprompt',
+        new lang_string('jsonprompt', 'qtype_aitext'),
+        new lang_string('jsonprompt_setting', 'qtype_aitext'),
+        'Return only a JSON object which enumerates a set of 2 elements.The JSON object should be in
 			this format: {feedback":"string","marks":"number"} where marks is a single value summing all marks.',
-        	PARAM_RAW, 20, 6
-	));
-
+        PARAM_RAW,
+        20,
+        6
+    ));
 }
 
diff --git a/version.php b/version.php
@@ -26,7 +26,7 @@
 defined('MOODLE_INTERNAL') || die();
 
 $plugin->component = 'qtype_aitext';
-$plugin->version   = 2024041401;
+$plugin->version   = 2024042201;
 $plugin->requires  = 2020110900;
 $plugin->maturity  = MATURITY_BETA;
 $plugin->dependencies = [