Fix CGO builds #32
Merged
Fix CGO builds #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31
There were some problems with the builds requiring CGO. CGO_ENABLED was not getting set to 1 correctly, which caused the versions that require it (Linux and MacOS) to be built without it and error when using
--clip. Upon fixing that, it was necessary to start using cross-compilers for Linux, which is what this PR adds.Currently, MacOS cannot be cross compiled yet so it must be compiled locally. The clipboard project is working on removing the CGO requirement, which once merged can again simplify this process (golang-design/clipboard#83).