feat: bump react-native to 0.76.6 on example app #73
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,20 +19,74 @@ explicit BigNumberCppAdapter() { | |
| } | ||
|
|
||
| void install(jsi::Runtime& runtime, std::shared_ptr<facebook::react::CallInvoker> jsCallInvoker) { | ||
|
There was a problem hiding this comment. I am getting a SIGSEGV here, check https://github.com/margelo/react-native-bignumber/blob/a8e9199da407b7cdf36e8b9cb6d557ed0194a22d/example/android/crash-log.txt There was a problem hiding this comment. Let's migrate it to Nitro after we made the RN 76 upgrade. WIth Nitro, we no longer need any of this |
||
| try { | ||
| if (!jsCallInvoker) { | ||
| __android_log_print(ANDROID_LOG_ERROR, "BigNumber", "jsCallInvoker is null in install"); | ||
| return; | ||
| } | ||
|
|
||
| auto workerQueue = std::make_shared<margelo::DispatchQueue::dispatch_queue>("Margelo MGBigNumber Thread"); | ||
| if (!workerQueue) { | ||
| __android_log_print(ANDROID_LOG_ERROR, "BigNumber", "Failed to create worker queue"); | ||
| return; | ||
| } | ||
|
|
||
| auto hostObject = std::make_shared<margelo::MGBigNumberHostObject>(jsCallInvoker, workerQueue); | ||
|
|
||
| if (!hostObject) { | ||
| __android_log_print(ANDROID_LOG_ERROR, "BigNumber", "Host object creation failed"); | ||
| return; | ||
| } | ||
|
|
||
| auto object = jsi::Object::createFromHostObject(runtime, hostObject); | ||
|
|
||
| // try { | ||
| // auto propNames = object.getPropertyNames(runtime); | ||
| // __android_log_print(ANDROID_LOG_INFO, "BigNumber", "Host object has %d properties", propNames.size(runtime)); | ||
| // } catch (const jsi::JSError& e) { | ||
| // __android_log_print(ANDROID_LOG_ERROR, "BigNumber", "Error inspecting host object: %s", e.what()); | ||
| // return; | ||
| // } | ||
|
|
||
| try { | ||
| runtime.global().setProperty(runtime, "__BigNumberProxy", std::move(object)); | ||
| __android_log_print(ANDROID_LOG_INFO, "BigNumber", "Property set successfully"); | ||
| } catch (const jsi::JSError& e) { | ||
| jni::throwNewJavaException("java/lang/IllegalStateException", "JSI Error setting property: %s", e.what()); | ||
| } catch (const std::exception& e) { | ||
| jni::throwNewJavaException("java/lang/IllegalStateException", "Exception setting property: %s", e.what()); | ||
| } catch (...) { | ||
| jni::throwNewJavaException("java/lang/IllegalStateException", "Unknown exception setting property"); | ||
| } | ||
| } catch (const std::exception& e) { | ||
| __android_log_print(ANDROID_LOG_ERROR, "BigNumber", "Exception in install: %s", e.what()); | ||
| } catch (...) { | ||
| __android_log_print(ANDROID_LOG_ERROR, "BigNumber", "Unknown exception in install"); | ||
| } | ||
| } | ||
|
|
||
| void nativeInstall(jlong jsiPtr, jni::alias_ref<facebook::react::CallInvokerHolder::javaobject> | ||
| jsCallInvokerHolder) { | ||
| __android_log_print(ANDROID_LOG_INFO, "BigNumber", "nativeInstall called"); | ||
|
|
||
| if (!jsCallInvokerHolder) { | ||
| __android_log_print(ANDROID_LOG_ERROR, "BigNumber", "jsCallInvokerHolder is null"); | ||
| return; | ||
| } | ||
|
|
||
| auto jsCallInvoker = jsCallInvokerHolder->cthis()->getCallInvoker(); | ||
| if (!jsCallInvoker) { | ||
| __android_log_print(ANDROID_LOG_ERROR, "BigNumber", "jsCallInvoker is null"); | ||
| return; | ||
| } | ||
|
|
||
| auto runtime = reinterpret_cast<jsi::Runtime*>(jsiPtr); | ||
| if (runtime) { | ||
| install(*runtime, jsCallInvoker); | ||
| } else { | ||
| // if runtime was nullptr, MGBigNumber will not be installed. This should only happen while Remote Debugging (Chrome), but will be weird either way. | ||
| __android_log_print(ANDROID_LOG_ERROR, "BigNumber", "Runtime pointer is null"); | ||
| } | ||
| } | ||
|
|
||
| static void registerNatives() { | ||
|
|
@@ -47,7 +101,9 @@ friend HybridBase; | |
| }; | ||
|
|
||
| JNIEXPORT jint JNICALL JNI_OnLoad(JavaVM *vm, void *) { | ||
| __android_log_print(ANDROID_LOG_INFO, "BigNumber", "JNI_OnLoad called"); | ||
| return facebook::jni::initialize(vm, [] { | ||
| __android_log_print(ANDROID_LOG_INFO, "BigNumber", "Registering natives"); | ||
| BigNumberCppAdapter::registerNatives(); | ||
| }); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| module.exports = { | ||
| root: true, | ||
| extends: '@react-native', | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,9 @@ | ||
| source 'https://rubygems.org' | ||
|
|
||
| # You may use http://rbenv.org/ or https://rvm.io/ to install and use this version | ||
| ruby ">= 2.6.10" | ||
|
|
||
| # Exclude problematic versions of cocoapods and activesupport that causes build failures. | ||
| gem 'cocoapods', '>= 1.13', '!= 1.15.0', '!= 1.15.1' | ||
| gem 'activesupport', '>= 6.1.7.5', '!= 7.1.0' | ||
| gem 'xcodeproj', '< 1.26.0' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch is pulled out from #72, it makes this library compile for RN 76 on Android, but it still does not work for the new architecure.
Seems like the library is not linked properly when fabric is enabled.