bumps openssl to 3.3.2 from 1.11.11-beta-1 #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renanmav
reviewed
Apr 17, 2025
Comment on lines
-128
to
+129
| // https://mvnrepository.com/artifact/com.android.ndk.thirdparty/openssl | ||
| implementation 'com.android.ndk.thirdparty:openssl:1.1.1l-beta-1' | ||
| // Add a dependency on OpenSSL | ||
| implementation "io.github.ronickg:openssl:3.3.2" |
There was a problem hiding this comment.
@peterpme why are you switching up from com.android.ndk.thirdparty to io.github.ronickg?
There was a problem hiding this comment.
Because you did :) I copied it directly from quick-crypto to solve the duplicate symbols stuff
https://github.com/margelo/react-native-quick-crypto/pull/559/files
There was a problem hiding this comment.
margelo/react-native-quick-crypto#351
ndk doesn't publish OpenSSL >= 3.
renanmav
approved these changes
May 13, 2025
|
Amazing, thank you @renanmav !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps OpenSSL to the same version quick-crypto has. Not sure if this is possible yet to be honest but wanted to get the ball rolling.
Fixes issue when using both libraries.
Thanks!
❯ nm -D node_modules/react-native-quick-crypto/../libcrypto.so | rg BN_CTX_new
000000000026a3b0 T BN_CTX_new@@OPENSSL_3.0.0
000000000026a36c T BN_CTX_new_ex@@OPENSSL_3.0.0
❯ nm -D node_modules/react-native-bignumber/../libcrypto.so | rg BN_CTX_new
00000000000aeac0 T BN_CTX_new@@OPENSSL_1_1_0