fix lint errors, fix gha js lint

Author: boorad

.github/workflows/validate-js.yml

@@ -67,10 +67,10 @@ jobs:
           bun install
 
       - name: Run ESLint (rnqc)
-        run: cd packages/react-native-quick-crypto && bun lint
+        run: cd packages/react-native-quick-crypto && bun lint-fix
 
       - name: Run ESLint (example)
-        run: cd example && bun lint
+        run: cd example && bun lint-fix
 
       - name: Verify no files have changed after auto-fix
         run: git diff --exit-code HEAD

bun.lockb

@@ -35,6 +35,6 @@ export default typescriptEslint.config(
   },
   // don't lint config files
   {
-    ignores: ['.prettierrc.js', '*.config.js'],
+    ignores: ['*.config.js'],
   },
 );

example/eslint.config.js

@@ -7,8 +7,10 @@
     "android": "react-native run-android",
     "ios": "react-native run-ios",
     "clean": "del-cli android/build node_modules/**/android/build lib",
+    "tsc": "tsc --noEmit",
+    "typescript": "tsc --noEmit",
     "lint": "eslint \"**/*.{js,ts,tsx}\"",
-    "lint-fix": "eslint \"src/**/*.{js,ts,tsx}\" --fix",
+    "lint-fix": "eslint \"**/*.{js,ts,tsx}\" --fix",
     "start": "react-native start",
     "pods": "cd ios && RCT_NEW_ARCH_ENABLED=1 pod install && rm -rf .xcode.env.local",
     "build:android": "cd android && ./gradlew assembleDebug --no-daemon --console=plain -PreactNativeArchitectures=arm64-v8a",

example/package.json

@@ -1,4 +1,4 @@
-module.exports = {
+export default {
   arrowParens: 'avoid',
   bracketSameLine: true,
   bracketSpacing: true,

example/.prettierrc.js renamed to example/prettier.config.js

@@ -1,12 +1,12 @@
 // @ts-expect-error - crypto-browserify is not typed
 import { randomBytes } from 'crypto-browserify'
-import type { RandomBytesFn } from '../types'
+import type { BenchmarkFn } from '../types'
 
-const randomBytes10: RandomBytesFn = () => {
+const randomBytes10: BenchmarkFn = () => {
   randomBytes(10)
 }
 
-const randomBytes1024: RandomBytesFn = () => {
+const randomBytes1024: BenchmarkFn = () => {
   randomBytes(1024)
 }
 

example/src/benchmarks/crypto-browserify/random.ts

@@ -1,11 +1,11 @@
 import rnqc from 'react-native-quick-crypto'
-import { RandomBytesFn } from '../types'
+import type { BenchmarkFn } from '../types'
 
-const randomBytes10: RandomBytesFn = () => {
+const randomBytes10: BenchmarkFn = () => {
   rnqc.randomBytes(10)
 }
 
-const randomBytes1024: RandomBytesFn = () => {
+const randomBytes1024: BenchmarkFn = () => {
   rnqc.randomBytes(1024)
 }
 

example/src/benchmarks/rnqc/random.ts

@@ -1 +1 @@
-export type RandomBytesFn = () => void
+export type BenchmarkFn = () => void

example/src/benchmarks/types.ts

@@ -1,4 +1,4 @@
-import { BenchmarkResult } from '../types/Results'
+import type { BenchmarkResult } from '../types/Results'
 
 export const formatNumber = (
   n: number,

example/src/benchmarks/utils.ts

@@ -1,5 +1,6 @@
 import { useCallback, useState } from 'react'
 import type { Benchmark, BenchmarkSuite, Suites } from '../types/Suite'
+import type { BenchmarkFn } from '../benchmarks/types'
 
 export const useBenchmarksList = (
   challenger: string
@@ -82,8 +83,7 @@ const loadBenchmarks = (suiteName: string, challenger: string): Benchmark[] => {
 
 // can't use dynamic strings here, as require() is compile-time
 /* eslint-disable @typescript-eslint/no-require-imports */
-// eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
-const allBenchmarks: Record<string, Record<string, Function>> = {
+const allBenchmarks: Record<string, Record<string, BenchmarkFn>> = {
   'rnqc/random': require('../benchmarks/rnqc/random').default,
   'crypto-browserify/random': require('../benchmarks/crypto-browserify/random')
     .default,