DNM: Coordinator nodes (an addition to read-only nodes) #3646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariadb-AlexanderPresniakov
force-pushed
the
coordinator-nodes
branch
from
edb67d0 to
0fc2664
Compare
mariadb-AlexanderPresniakov
changed the title
mariadb-AlexanderPresniakov
changed the base branch from
stable-23.10
to
feat/MCOL-5964-5861-5863-um-only-node
* feat(cmapi): add read_only param for API add node endpoint * style(cmapi): fixes for string length and quotes Add dbroots of other nodes to the read-only node On every node change adjust dbroots in the read-only nodes Fix logging (trace level) in tests
…th DML This patch changes logic from counting all nodes to counting only read-write nodes when messaging about DML operations.
This patch introduces centralized logic of selecting what dbroot is accessible in PrimProc on what node. The logic is in OamCache for time being and can be moved later.
mariadb-SergeyZefirov
force-pushed
the
feat/MCOL-5964-5861-5863-um-only-node
branch
from
d9212ae to
5aa2a82
Compare
…at do not add dbroot of other nodes)
mariadb-AlexanderPresniakov
force-pushed
the
coordinator-nodes
branch
from
75350df to
573b492
Compare
mariadb-AlexanderPresniakov
force-pushed
the
coordinator-nodes
branch
from
573b492 to
a193104
Compare
…cause nodes are only deactivated)
mariadb-AlexanderPresniakov
changed the base branch from
feat/MCOL-5964-5861-5863-um-only-node
to
stable-23.10
mariadb-LeonidFedorov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@drrtuy requested a new mode to be implemented: coordinator-only mode is almost identical to read-only mode, but it doesn't add dbroots of other nodes to the node.
So this new mode it is a subset of functionality of read-only mode. To avoid over-complicating everything, i added a new parameter
add_other_nodes_dbrootstoadd_node, it is true by default.So
read_only=false and add_other_nodes_dbroots=false --> normal mode
read_only=true and add_other_nodes_dbroots=true --> read_only mode
read_only=true and add_other_nodes_dbroots=false --> coordinator_only mode
read_only=false and add_other_nodes_dbroots=true --> invalid combination, will raise an exception