Fix compilation for gcc 15 with musl libc #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when building on Gentoo with the musl profile, gcc 15 reports the following errors: > In file included from /var/tmp/portage/dev-db/mariadb-11.8.3-r2/work/mysql/wsrep-lib/src/provider_options.cpp:20: > /var/tmp/portage/dev-db/mariadb-11.8.3-r2/work/mysql/wsrep-lib/include/wsrep/provider_options.hpp:114:30: error: unknown type name 'int64_t' > 114 | option_value_int(int64_t value) > | ^ > /var/tmp/portage/dev-db/mariadb-11.8.3-r2/work/mysql/wsrep-lib/include/wsrep/provider_options.hpp:127:13: error: unknown type name 'int64_t' > 127 | int64_t value_; > | ^ > /var/tmp/portage/dev-db/mariadb-11.8.3-r2/work/mysql/wsrep-lib/include/wsrep/provider_options.hpp:127:21: warning: private field 'value_' is not used [-Wunused-private-field] > 127 | int64_t value_; > | ^ > 1 warning and 2 errors generated. The root cause is that including <memory> pulls in bits/align.h, and GCC 15 has removed the implicit inclusion of <stdint.h> from bits/align.h. As a result, int64_t is no longer defined unless <cstdint> is explicitly included. This patch adds the missing <cstdint> include to fix the build. Signed-off-by: Z. Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when building on Gentoo with the musl profile, gcc 15 reports the following errors:
The root cause is that including <memory> pulls in bits/align.h, and GCC 15 has removed the implicit inclusion of <stdint.h> from bits/align.h. As a result, int64_t is no longer defined unless <cstdint> is explicitly included.
This patch adds the missing <cstdint> include to fix the build.