refactor: remove base vpc and change in perimeter #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -744,7 +744,7 @@ An environment variable `GOOGLE_IMPERSONATE_SERVICE_ACCOUNT` will be set with th | |||
|
|
|||
| 1. Update `common.auto.tfvars` file with values from your GCP environment. | |||
| See any of the envs folder [README.md](../3-networks-hub-and-spoke/envs/production/README.md#inputs) files for additional information on the values in the `common.auto.tfvars` file. | |||
| 1. You must add your user email in the variable `perimeter_additional_members` to be able to see the resources created in the restricted project. | |||
| 1. You must add your user email in the variable `perimeter_additional_members` to be able to see the resources created in the shared vpc project. | |||
There was a problem hiding this comment.
NIT: maybe this would be more concise?
Suggested change
| 1. You must add your user email in the variable `perimeter_additional_members` to be able to see the resources created in the shared vpc project. | |
| 1. You must add your user email in the variable `perimeter_additional_members` to be able to see the resources that are created in the shared vpc-sc perimeter. |
4-projects/README.md
Outdated
| @@ -371,6 +371,23 @@ For example, to create a new business unit similar to business_unit_1, run the f | |||
| ./tf-wrapper.sh apply development | |||
| ``` | |||
|
|
|||
| ### Include APP Infra Pipeline terraform service account in the perimeter | |||
|
|
|||
| App Infra Pipeline terraform service account needs to be added to the VPC-SC perimeter. | |||
There was a problem hiding this comment.
suggestion: adding a reason why the app infra pipeline should be added to the perimeter
There was a problem hiding this comment.
question:
- does this change need to be made for both the cloudbuild and local terraform deployments?
- it is a pre-requisite?
daniel-cit
reviewed
Jan 16, 2025
0-bootstrap/terraform.example.tfvars
Outdated
| @@ -168,4 +168,4 @@ default_region_kms = "us" | |||
| // For GitHub OAuth see: https://developer.hashicorp.com/terraform/cloud-docs/vcs/github | |||
| // For GitHub Enterprise see: https://developer.hashicorp.com/terraform/cloud-docs/vcs/github-enterprise | |||
| // For GitLab.com see: https://developer.hashicorp.com/terraform/cloud-docs/vcs/gitlab-com | |||
| // For GitLab EE/CE see: https://developer.hashicorp.com/terraform/cloud-docs/vcs/gitlab-eece | |||
| // For GitLab EE/CE see: https://developer.hashicorp.com/terraform/cloud-docs/vcs/gitlab-eece | |||
There was a problem hiding this comment.
missing empty line at the end of file
…erraform-example-foundation into refactor/remove-base-VPC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks, this PR contains the following network refactoring:
perimeter change, now with a single perimeter that includes all foundation projects
the removal of the base project, now containing only restricted project