dief@t adds additional data point with wrong timestamp #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of dief@t adds an additional data point for each approach with the maximum time t, where t is either the parameter given or the maximum t of all approaches. This leads to wrong values of dief@t if an approach finishes earlier than the others.
Assuming the following data
Approach a1 is less efficient but is generates answers continuously while a2 is a blocking approach. The current implementation adds the data points (a1, 2746, 379966378.0) and (a2, 2746, 379966378.0). Hence, the area-under-the-curve and the value for dief@t for a2 is higher than the one for a1 which is clearly wrong. The value of dief@t for a2 should be 0.0. This PR provides the necessary changes to fix this issue.