state: do not overwrite currentContract #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the currentContract is already set we should not overwrite it For instance, the user can look to a safe without being log in Then he logs in, then he should still look to the safe he was looking at
Pilou97
force-pushed
the
pilou@fix-current-contract
branch
from
8f3dd74
to
a2ffde7
Compare
quentin-burg
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the currentContract is already set we should not overwrite it
How to reproduce the bug:
invalid-contractWhat is happening is that the
loginaction overwritecurrentContracts. When the user has not yet import contracts the value is set to null, even if the user was looking to a safe