improvement: add 'auto' as an option for auto_discovery #4043
+106
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Nice! Is the value of this option mainly for LLM and code completion? Because the latency to discover tables for sqlite, postgres is pretty low. But yeah, we should make auto discovery smarter for the future, eg. check number of schemas, tables b4 discovering. Async discovery. All of these optimizations fit under "auto". maybe leave it as false for columns for now 🤔, mysql and postgres can have a lot of tables. We should work to make it async I think. |
Light2Dark
previously approved these changes
Mar 9, 2025
|
Breaking changes detected in the OpenAPI specification! |
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.11.18-dev25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds 'auto' as an option for
auto_discovery, which is nice for things likesqliteso these can be discovered while Snowflake or Bigquery don't need to be.Should we also do this for
columns?cc @Light2Dark
Cons:
auto