-
Notifications
You must be signed in to change notification settings - Fork 74
VLM for Marin #2298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ruili33
wants to merge
19
commits into
marin-community:main
Choose a base branch
from
ruili33:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
VLM for Marin #2298
Changes from 11 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
9cb77cb
Adding support for Siglip and Siglip2 vision encoders.
ruili33 0611a95
Merge branch 'marin-community:main' into main
ruili33 0ad0779
Merge branch 'marin-community:main' into main
ruili33 107e102
initial VLM commit
ruili33 27df0ec
fix test data loading
ruili33 dbd300b
fix tests on new environment
ruili33 4158820
fix oom error
ruili33 f07d615
Padding siglip for attention. Adding support for explicit mask on spl…
ruili33 09d524d
fix lint problems
ruili33 4833cda
Merge branch 'main' into main
ruili33 12a2ea5
Delete output
ruili33 0f6e2d8
Update launch_vlm_training.py
ruili33 be94e27
fixed image.py
ruili33 fb8114b
Merge branch 'main' of github.com:ruili33/marin
ruili33 2597207
fix number of patches
ruili33 5936b3b
update for test
ruili33 bf4af14
adding generation tests
ruili33 b25cd75
fix linter issue
ruili33 60a0258
Merge branch 'marin-community:main' into main
ruili33 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't want the concrete mesh inside jit in general since it breaks compilation caching. can we do abstract?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also why is this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not so necessary. I added this because it would throws errors for ckpt saved outside of meshes because that it need a no empty mesh to work.