Surface RLJob errors to Ray, fail the job accordingly #2311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonromai
force-pushed
the
romain/surface-rljob-errors
branch
2 times, most recently
from
477dc1c to
9ea19d2
Compare
Contributor
Author
|
I tested this on Bottom run ^ doesn't have this fix, runs for ever (I had to kill it) and the top run, includes this fix, failed after 3 attempts. |
yonromai
force-pushed
the
romain/surface-rljob-errors
branch
from
9ea19d2 to
8a9f5e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2306
Status: Blocked on chris/exp-rl being out of sync withmain. See Discord discussion here.