-
Notifications
You must be signed in to change notification settings - Fork 74
Update PR template given we now use it for commit descriptions. #2419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
435f087
The PR description is now used as the commit message.
rjpower 0a4b405
Update PR template given we now use it for commit descriptions.
rjpower 1df8a8e
Add Fixes notation and issue reference guidance to PR template
github-actions[bot] 1677d7e
Refine pull request template for better guidance
rjpower 9c64e24
Merge branch 'main' into rjpower/20260120-cleanup-pr-template
rjpower File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,23 @@ | ||
| ## Description | ||
| Include a summary of the changes and the related issue if any. | ||
|
|
||
| Fixes #(issue number) | ||
| A good description is a paragraph or so describing the changes you made and the | ||
| motivation. You may follow this with a few bullets for specific changes, but | ||
| try to keep it concise. | ||
|
|
||
| [Please include a summary of the changes and the related issue.] | ||
| e.g. | ||
|
|
||
| Title: [RL] Fix loss: use global token normalization instead of per-example | ||
|
|
||
| ## Checklist | ||
| """ | ||
| This fixes a regression in the DAPO loss computation by switching | ||
| from per-example normalization (/ n_i) back to global token | ||
| normalization (/ N). Per-example normalization gives shorter responses | ||
| disproportionately more gradient weight, which hurts math reasoning | ||
| tasks where correct answers often require detailed, longer derivations. | ||
| Global normalization weights all examples equally regardless of response | ||
| length. | ||
| """ | ||
|
|
||
| - [ ] You ran `uv run python infra/pre-commit.py --all-files` to lint/format your code | ||
| - [ ] You ran 'pytest' to test your code | ||
| - [ ] Delete this checklist | ||
| <!-- If this PR addresses an existing issue, include "Fixes #XXXX" below. --> | ||
| <!-- For ongoing work, PRs should reference an existing issue. Delete this comment when done. --> | ||
| Fixes # | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.