Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,23 @@
## Description
Include a summary of the changes and the related issue if any.

Fixes #(issue number)
A good description is a paragraph or so describing the changes you made and the
motivation. You may follow this with a few bullets for specific changes, but
try to keep it concise.

[Please include a summary of the changes and the related issue.]
e.g.

Title: [RL] Fix loss: use global token normalization instead of per-example

## Checklist
"""
This fixes a regression in the DAPO loss computation by switching
from per-example normalization (/ n_i) back to global token
normalization (/ N). Per-example normalization gives shorter responses
disproportionately more gradient weight, which hurts math reasoning
tasks where correct answers often require detailed, longer derivations.
Global normalization weights all examples equally regardless of response
length.
"""

- [ ] You ran `uv run python infra/pre-commit.py --all-files` to lint/format your code
- [ ] You ran 'pytest' to test your code
- [ ] Delete this checklist
<!-- If this PR addresses an existing issue, include "Fixes #XXXX" below. -->
<!-- For ongoing work, PRs should reference an existing issue. Delete this comment when done. -->
Fixes #