Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring for more modularity #58
base: main
Are you sure you want to change the base?
Refactoring for more modularity #58
Changes from 4 commits
6e8d4c0
5b8771d
fc854a7
59510cd
4249185
6cfa996
0a7bdc4
b929056
5858f89
506be0d
215ac32
c6dae3b
cabb211
a0c5d46
5959e6b
0ebbc63
29af921
c394167
bf799ef
ddbf1f3
f9361d8
3ac3543
b2ed80e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we convert this into an assert? like the one at line 59?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you mean here about
assert
to be used here.Do you mean like
assert(voteRecord, ErrorMessage.NO_PUBLIC_KEY)
.That's not possible currently as how SDK is designed (as far as I understand it). When the
voteRecord
is not provided to the method then the caller does not expect an error. It's a normal flow of code.When the instruction is not returned back to the caller the caller behaves differently.
It's not much intuitive I assume. Maybe the way how SDK API is designed here should be adjusted to be clearer.
WDYT?
The caller should behave differently when he provides no pubkey. The original code of SDK is not mine but it's from MJ so I just trying to understand the behaviour and adapt it.