Skip to content

Commit

Permalink
Added "v" before version in UrlRoot property
Browse files Browse the repository at this point in the history
The new documentation expects the version segment to be prepended with `v` otherwise it will go to a `404` page.
  • Loading branch information
KyleNeedham authored and samccone committed Oct 22, 2014
1 parent bd1f02c commit 490b9ff
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions spec/javascripts/error.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,12 @@ describe('Marionette.Error', function() {
expect(this.error).to.contain({
name: 'Bar',
message: 'Foo',
url: 'http://marionettejs.com/docs/' + Marionette.VERSION + '/Baz'
url: 'http://marionettejs.com/docs/v' + Marionette.VERSION + '/Baz'
});
});

it('should output the correct string', function() {
expect(this.error.toString()).to.equal('Bar: Foo See: http://marionettejs.com/docs/' + Marionette.VERSION + '/Baz');
expect(this.error.toString()).to.equal('Bar: Foo See: http://marionettejs.com/docs/v' + Marionette.VERSION + '/Baz');
});
});

Expand Down Expand Up @@ -93,12 +93,12 @@ describe('Marionette.Error', function() {
expect(this.error).to.contain({
name: 'Foo',
message: 'Bar',
url: 'http://marionettejs.com/docs/' + Marionette.VERSION + '/Baz'
url: 'http://marionettejs.com/docs/v' + Marionette.VERSION + '/Baz'
});
});

it('should output the correct string', function() {
expect(this.error.toString()).to.equal('Foo: Bar See: http://marionettejs.com/docs/' + Marionette.VERSION + '/Baz');
expect(this.error.toString()).to.equal('Foo: Bar See: http://marionettejs.com/docs/v' + Marionette.VERSION + '/Baz');
});
});

Expand Down
2 changes: 1 addition & 1 deletion src/marionette.error.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
var errorProps = ['description', 'fileName', 'lineNumber', 'name', 'message', 'number'];

Marionette.Error = Marionette.extend.call(Error, {
urlRoot: 'http://marionettejs.com/docs/' + Marionette.VERSION + '/',
urlRoot: 'http://marionettejs.com/docs/v' + Marionette.VERSION + '/',

constructor: function(message, options) {
if (_.isObject(message)) {
Expand Down

0 comments on commit 490b9ff

Please sign in to comment.