Skip to content

Commit

Permalink
Merge pull request #2906 from JSteunou/patch-1
Browse files Browse the repository at this point in the history
Remove use of deprecated $.selector
  • Loading branch information
paulfalgout committed Mar 8, 2016
2 parents ab575c0 + fd44e21 commit 6025f44
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/region.js
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ const Region = MarionetteObject.extend({
if (this.getOption('allowMissingEl')) {
return false;
} else {
throw new MarionetteError('An "el" ' + this.$el.selector + ' must exist in DOM');
throw new MarionetteError(`An "el" must exist in DOM for this region ${this.cid}`);
}
}
return true;
Expand Down
2 changes: 1 addition & 1 deletion test/unit/region.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ describe('region', function() {
it('should throw an exception saying an "el" doesnt exist in DOM', function() {
expect(function() {
this.region.show(new this.MyView());
}.bind(this)).to.throw('An "el" #not-existed-region must exist in DOM');
}.bind(this)).to.throw('An "el" must exist in DOM for this region ' + this.region.cid);
});

it('should not have a view', function() {
Expand Down

0 comments on commit 6025f44

Please sign in to comment.