Merge pull request #1452 from marionettejs/sjs/fix-behavior-ui-bug

Fix behavior prototype event clobbering
marionettejs · Jun 6, 2014 · 64f2cc9 · 64f2cc9
2 parents 324141d + 47985f0
commit 64f2cc9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/spec/javascripts/behaviors.spec.js b/spec/javascripts/behaviors.spec.js
@@ -338,6 +338,10 @@ describe("Behaviors", function(){
       });
     });
 
+    it('should not clobber the event prototype', function() {
+      expect(hold.test.prototype.events['click @ui.doge']).toEqual('onDogeClick');
+    });
+
     it("should set the behavior UI element", function() {
       v = new V;
       v.render();

diff --git a/src/marionette.behaviors.js b/src/marionette.behaviors.js
@@ -93,7 +93,7 @@ Marionette.Behaviors = (function(Marionette, _) {
 
       _.each(behaviors, function(b, i) {
         var _events = {};
-        var behaviorEvents = _.result(b, 'events') || {};
+        var behaviorEvents = _.clone(_.result(b, 'events')) || {};
         var behaviorUI = _.result(b, 'ui');
 
         // Construct an internal UI hash first using