Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR to fix the unintended BufferOverflowError #12

Merged
merged 11 commits into from
Mar 27, 2024
Merged

PR to fix the unintended BufferOverflowError #12

merged 11 commits into from
Mar 27, 2024

Conversation

clementwanjau
Copy link
Contributor

Changes

This PR addresses the following issues:

  • An unintended buffer overflow issue where instead of reading the remaining bytes in the stream, an error would be returned if the buffer length exceeds the length of the stream.
  • It also removes the no_libc option in the cli which is redundant.

@clementwanjau
Add binary security checks.
e66e575
@clementwanjau
Some Refactors
9e58163
@clementwanjau
Use the Function pointer syntax to map errors
487b2dc
@clementwanjau
Check if we need the libc and handle it gracefully
71da571
@clementwanjau
Update the readme.md.
01be805
@clementwanjau
Provide security checks options as cmdline arguments
46d661c
@clementwanjau
Remove the cmdline module
6b6c186
@clementwanjau
Fix the smda extractor to read the rest of the bytes present in the b…
0be66b2 
…uffer if the buffer length exceeds the end of file.
@clementwanjau
Merge remote-tracking branch 'origin/master'
a3ef63a 
# Conflicts:
#	Cargo.toml
#	README.md
#	examples/capa_cli.rs
#	src/extractor/smda.rs
#	src/lib.rs
#	src/security/elf/checked_functions.rs
#	src/security/elf/mod.rs
#	src/security/elf/needed_libc.rs
#	src/security/mod.rs
#	src/security/options/mod.rs
#	src/security/options/status.rs
#	src/security/parser.rs
#	src/security/pe.rs
@clementwanjau
Fix the smda extractor to read the rest of the bytes present in the b…
133abd5 
…uffer if the buffer length exceeds the end of file.
@clementwanjau
Remove the no_libc param from the cli.
809a775
@marirs marirs merged commit f17ea45 into marirs:master Mar 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clementwanjau @marirs