Era5 implementation #3
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Mark,
this part of the code should adress the era5 implementation - reading all files is handles in the read_requested_data.py, configuration for this is set in the config.py file.
The height calculation utils for era5 are basically copied from the awe-era5 repo.
For now (for better comparison between era5 and dowa results I use the dowa lat/lon indices to define a position. In the long run I think we will want to define latitude/longitude and then read the data
As it was not clear how we wanted to handle multiple locations, I didn't want to code this before, just to avoid double work/concepting. When you give your input on multiple locations next week it will probably be much clearer.
Multiple locations / location settings in general could thus be addressed in a new issue?
in my repo, the evaluation branch includes the code to calculate the pc/clustering differences. I'll start a pull request for that a bit later, when the tests we discussed are also implemented.
Cheers,
Lavinia