Adding visibility to class members and abstract/final to classes#52
Adding visibility to class members and abstract/final to classes#52thuttinpasseron wants to merge 2 commits into
Conversation
Signed-off-by: Thibault HUTTIN-PASSERON <87776406+thuttinpasseron@users.noreply.github.com>
markstory
left a comment
There was a problem hiding this comment.
Looks ok on first read. As for tests, there is a test directory with some source documents. We use these documents to have examples of common options to generate HTML output. I visually check these before each release 😊
Looking forward to see this. Did you start this project already ? |
|
@markstory hello, just wanted to ask if this is abandoned? About to start for generator of rst from PHP code (apparently, everyone does that :D ) ... |
Currently yes, as I forgot about it. There have been a bunch of changes in this package and the changes can't be merged anymore. If these changes were rebased and put into a new pull request, I don't see a reason why visibility markers couldn't be included. |
Hi,
I'm planning to work on an autodoc plugin for PHP using a method similar to sphinx_js, which means I'll rely on phpDocumentor to parse the docblocks into xml and then use sphinx to parse the XML into rst.
I found that the abstact/final keywords were not present for class-like structures, and that the visibility of class members wasn't implemented as well. This PR aims to correct this while staying backwards compatible.
I'm not familiar with how you want to test this, so please tell me if I've done something wrong during my commits.
Thanks in advance for your review.