Improve tmux idle detection with robust prompt recognition#4
Open
jsell-rh wants to merge 1 commit intomarkturansky:mainfrom
Open
Improve tmux idle detection with robust prompt recognition#4jsell-rh wants to merge 1 commit intomarkturansky:mainfrom
jsell-rh wants to merge 1 commit intomarkturansky:mainfrom
Conversation
Rewrite tmuxIsIdle to use a comprehensive set of idle indicators instead of only matching the Claude Code '>' prompt. New patterns recognized: - Shell prompts: $, %, #, >, ❯, » (with false-positive guards for '=>', '->', '50%', 'line #3') - Claude Code ❯ prompt with auto-suggested text after it - Claude Code vim-mode status bar ('-- INSERT --', '-- NORMAL --') - OpenCode status bar ('ctrl+p commands') - Generic idle keywords ('waiting for input', 'ready', etc.) - Heavy box-drawing character ┃ (U+2503) in addition to light │ (U+2502) Also changes the default-on-error behavior from 'assume busy' to 'assume idle', preventing agents from being falsely skipped during broadcasts when pane capture fails transiently. Includes comprehensive table-driven tests for lineIsIdleIndicator (28 cases) and isShellPrompt (16 cases).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tmuxIsIdle()to recognize a comprehensive set of idle indicators beyond just the Claude Code>prompt❯characterNew idle patterns recognized
$,%,#,>,❯,»with false-positive guards (rejects=>,->,50%,line #3)❯with suggestion: lines starting with❯are idle regardless of trailing text-- INSERT --,-- NORMAL --ctrl+p commands┃(U+2503) in addition to light│(U+2502)Changes
internal/coordinator/tmux.go: NewlineIsIdleIndicator()andisShellPrompt()functions, rewrittentmuxIsIdle()internal/coordinator/server_test.go: 28 test cases forTestLineIsIdleIndicator, 16 forTestIsShellPromptTesting
-race