Fix message system: render in /raw, preserve on updates, integrate into agent workflow#5
Open
jsell-rh wants to merge 5 commits intomarkturansky:mainfrom
Open
Fix message system: render in /raw, preserve on updates, integrate into agent workflow#5jsell-rh wants to merge 5 commits intomarkturansky:mainfrom
jsell-rh wants to merge 5 commits intomarkturansky:mainfrom
Conversation
…are empty The callers of BroadcastCheckIn and SingleAgentCheckIn always pass empty strings for checkModel and workModel, causing '/model ' (with no model name) to be sent to agents. This resulted in broken model switch attempts that would time out or fail. Now when checkModel/workModel are empty, the model switch steps are skipped entirely and the check-in runs on whatever model the agent is already using. Model economy still works if actual model names are passed.
Rewrite tmuxIsIdle to use a comprehensive set of idle indicators instead of only matching the Claude Code '>' prompt. New patterns recognized: - Shell prompts: $, %, #, >, ❯, » (with false-positive guards for '=>', '->', '50%', 'line #3') - Claude Code ❯ prompt with auto-suggested text after it - Claude Code vim-mode status bar ('-- INSERT --', '-- NORMAL --') - OpenCode status bar ('ctrl+p commands') - Generic idle keywords ('waiting for input', 'ready', etc.) - Heavy box-drawing character ┃ (U+2503) in addition to light │ (U+2502) Also changes the default-on-error behavior from 'assume busy' to 'assume idle', preventing agents from being falsely skipped during broadcasts when pane capture fails transiently. Includes comprehensive table-driven tests for lineIsIdleIndicator (28 cases) and isShellPrompt (16 cases).
This was referenced Mar 6, 2026
Fix broadcast model switching: skip /model when model names are empty
Improve tmux idle detection with robust prompt recognition
…protocol Messages sent via the dashboard were stored in agent JSON but never visible to agents because: 1. The /raw markdown endpoint did not render them 2. Agent status updates wiped the Messages field This commit fixes both issues and makes messages a first-class feature: Server changes: - Render messages in /raw markdown under '#### Messages' with sender, timestamp, and content so agents see them during check-ins - Preserve Messages and Documents fields when agents POST status updates - Show pending messages in the ignition response with bold 'unread' header - Add messaging protocol rule to ignition output Protocol and command changes: - Add 'Send message' endpoint to protocol.md endpoints table - Add rule 9: check your messages on /raw, send via /message endpoint - Update boss.check.md: scan for messages, acknowledge, act on instructions - Update boss.ignite.md: document message checking and sending rules Tests (9 new): - TestMessagePostEndpoint: POST, verify delivery and retrieval - TestMessagePreservedOnAgentUpdate: verify messages survive agent updates - TestMessageRenderedInMarkdown: verify #### Messages in /raw output - TestMessageValidation: missing sender, empty message, wrong method - TestMessageLimit: verify 50-message cap - TestMessageSSEBroadcast: verify agent_message SSE event - TestMessageToNonexistentAgentCreatesAgent: auto-create on message - TestIgnitionEndpoint: verify structure, tmux registration, /message docs - TestIgnitionShowsPendingMessages: verify pending messages in ignition
jsell-rh
force-pushed
the
feat/message-system
branch
from
9d59b4f to
57aa9cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Messages sent via the dashboard were stored in agent JSON but never visible to agents because:
/rawmarkdown endpoint did not render themMessagesfieldThis PR fixes both issues and makes the mailbox message system a first-class feature that agents discover during ignition and check for during every check-in.
Server changes
/raw: New#### Messagessection inrenderAgentSection()with sender, timestamp, and contentMessagesandDocumentsfields are no longer wiped when agents POST status updates/ignition/{agent}response now includes a "Pending Messages" section and documents the/messageendpoint in protocol rulesProtocol and command changes
protocol.md: Added "Send message" endpoint row and rule 9 (check your messages)boss.check.md: Agents now scan for#### Messages, acknowledge them, and act on instructions (4 steps instead of 3)boss.ignite.md: New rules for checking messages and sending messages to other agentsTests (9 new)
TestMessagePostEndpointTestMessagePreservedOnAgentUpdateTestMessageRenderedInMarkdown#### Messagesappears in/rawoutputTestMessageValidationTestMessageLimitTestMessageSSEBroadcastagent_messageSSE event firesTestMessageToNonexistentAgentCreatesAgentTestIgnitionEndpoint/messagedocsTestIgnitionShowsPendingMessagesTesting
-race