Skip to content

Commit

Permalink
Remove extraneous flags (#38)
Browse files Browse the repository at this point in the history
  • Loading branch information
Miladiir authored Jun 17, 2024
1 parent 979edb2 commit 15672d2
Showing 1 changed file with 7 additions and 9 deletions.
16 changes: 7 additions & 9 deletions zfs-inplace-rebalancing.sh
Original file line number Diff line number Diff line change
Expand Up @@ -93,21 +93,19 @@ function rebalance () {
# Linux

# --reflink=never -- force standard copy (see ZFS Block Cloning)
# -a -- keep attributes
# -d -- keep symlinks (dont copy target)
# -a -- keep attributes, includes -d -- keep symlinks (dont copy target) and
# -p -- preserve ACLs to
# -x -- stay on one system
# -p -- preserve ACLs too
cp --reflink=never -adxp "${file_path}" "${tmp_file_path}"
cp --reflink=never -ax "${file_path}" "${tmp_file_path}"
elif [[ "${OSTYPE,,}" == "darwin"* ]] || [[ "${OSTYPE,,}" == "freebsd"* ]]; then
# Mac OS
# FreeBSD

# -a -- Archive mode. Same as -RpP.
# -a -- Archive mode. Same as -RpP. Includes preservation of modification
# time, access time, file flags, file mode, ACL, user ID, and group
# ID, as allowed by permissions.
# -x -- File system mount points are not traversed.
# -p -- Cause cp to preserve the following attributes of each source file
# in the copy: modification time, access time, file flags, file mode,
# ACL, user ID, and group ID, as allowed by permissions.
cp -axp "${file_path}" "${tmp_file_path}"
cp -ax "${file_path}" "${tmp_file_path}"
else
echo "Unsupported OS type: $OSTYPE"
exit 1
Expand Down

0 comments on commit 15672d2

Please sign in to comment.