Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand test #59

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Expand test #59

wants to merge 5 commits into from

Conversation

meo-pill
Copy link
Contributor

@meo-pill meo-pill commented Jan 7, 2025

The inspiration for this pr is from the @adiov reply on the #57.

add the vscode config file to gitignore
- test 1000 1Ko file
- test 5 1 Go file
- test whit both
prevent wordspliting
remove the db before testing for more accurate time
- use of gdate (coreutils) for macOS
- switch to `ns` in place of `ms` for freeBSD
@adiov
Copy link
Contributor

adiov commented Jan 8, 2025

This is an excellent addition. I'm running this script against a large TrueNAS SCALE cluster, multiple servers with hundreds of TB each. It's a one-time operation for now, but even single-digit % time savings are very impactful. Making it easier to test time will encourage me, and probably others, to find more ways to make this script faster.

@meo-pill
Copy link
Contributor Author

meo-pill commented Jan 8, 2025

I'm waiting for the #57 to be merged, but I think I have found a way to do the checksum calculation in parallel, so it would be close to a 2x improvement. @adiov

@markusressel
Copy link
Owner

#57 is merged now.

@meo-pill
Copy link
Contributor Author

meo-pill commented Jan 9, 2025

This can be merged I do it in another pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants